Streamline calls to PageSummary and MediaList. #5239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note that this is based on top of #5238)
getPageSummary()
call where the optionalReferer
parameter came first for some reason, which required us to pass an explicitnull
everywhere this call was made. Let's make this parameter come second, along with all other optional parameters, so that any overloaded calls can be simplified.SavedPageSyncService
where we were making the calls to retrieve the PageSummary, MediaList, and MobileHtml, those calls were being made serially, not in parallel. Let's useasync{}
to make these calls all at once, and speed up saving articles for offline usage.