Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline calls to PageSummary and MediaList. #5239

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Jan 17, 2025

(note that this is based on top of #5238)

  • Previously we had a getPageSummary() call where the optional Referer parameter came first for some reason, which required us to pass an explicit null everywhere this call was made. Let's make this parameter come second, along with all other optional parameters, so that any overloaded calls can be simplified.
  • In the SavedPageSyncService where we were making the calls to retrieve the PageSummary, MediaList, and MobileHtml, those calls were being made serially, not in parallel. Let's use async{} to make these calls all at once, and speed up saving articles for offline usage.

@dbrant dbrant added the Minor Minor stuff label Jan 17, 2025
@cooltey cooltey merged commit e9a5d1a into mediaListRevIssues Jan 17, 2025
2 checks passed
@cooltey cooltey deleted the savePageCalls branch January 17, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Minor stuff
Development

Successfully merging this pull request may close these issues.

2 participants